Skip to content
This repository was archived by the owner on Jun 19, 2020. It is now read-only.

Conversation

@istr
Copy link
Collaborator

@istr istr commented Feb 2, 2016

Branch to prepare 1.1.0-beta4, addressing #1365.

@n1k0 @mickaelandrieu @hexid @paazmaya If you prefer a branch in https://github.com/n1k0/casperjs (maybe better because you could update it) I will relocate it there.

@mickaelandrieu
Copy link
Member

Hi @istr I don't think we need a dedicated branch for this beta, imo we should release 1.1.0 stable as soon as possible.

edit: mono is probably missing :)

@istr
Copy link
Collaborator Author

istr commented Feb 2, 2016

@mickaelandrieu Ok, agreed. Maybe open an issue to collect which bugs to fix and create a 1.1.0 branch for the few remaining steps?

@mickaelandrieu
Copy link
Member

@istr 👍 yup! let me know when you want me to merge :)

@n1k0
Copy link
Member

n1k0 commented Feb 2, 2016

The changes look good to me.

@mickaelandrieu
Copy link
Member

All green ! Do you want to clean your commit history before merge ?

Close #532; close #1076; add dotNET test for 2.1.1; add warning for engine prerequisite; update installation info.
@istr
Copy link
Collaborator Author

istr commented Feb 2, 2016

Rebased / merged. @mickaelandrieu If you are happy with this, feel free to merge.

I will then tag the merged master appropriately and prepare the packaging of it this evening.

mickaelandrieu added a commit that referenced this pull request Feb 2, 2016
@mickaelandrieu mickaelandrieu merged commit 3aa6f76 into casperjs:master Feb 2, 2016
@mickaelandrieu
Copy link
Member

thank you very much @istr !

@mickaelandrieu
Copy link
Member

@istr no tag for 1.1-beta4 ?

@istr
Copy link
Collaborator Author

istr commented Feb 2, 2016

@mickaelandrieu See https://github.com/n1k0/casperjs/releases when logged in. Preparing the entry and change log there as a draft. I could push that tag now, if you like -- but it could be done automatically by means of publishing the release entry... :-)

@mickaelandrieu
Copy link
Member

@istr 👍 and now let's work on 1.1 stable :D CasperJS is not dead!

@istr
Copy link
Collaborator Author

istr commented Feb 2, 2016

@mickaelandrieu Yes, indeed. Could you please have a short look at
https://github.com/n1k0/casperjs/releases/tag/untagged-316151748ff029cd4245 before I publish it?
Thank you. :-)

The npm release will follow tomorrow, I am getting too tired and do not want to make avoidable mistakes there.

@istr istr deleted the feature/package-1.1.0-beta4 branch February 2, 2016 21:58
@mickaelandrieu
Copy link
Member

It's good to me :)

@istr
Copy link
Collaborator Author

istr commented Feb 3, 2016

Ok. Published. npm packages follow soon.

@paazmaya
Copy link
Contributor

paazmaya commented Feb 3, 2016

This is great news! and great achievement, thank you @istr !

@n1k0
Copy link
Member

n1k0 commented Feb 3, 2016

A bunch of thanks @istr for having taken care of this, you rock :)

@istr
Copy link
Collaborator Author

istr commented Feb 3, 2016

Thanks... It was a pleasure for me. :-)
Let's see if/how we can re-gain some traction on this invaluable project.

BTW I bumped the "hipstered" version to 1.1-beta4 recently.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants