Replace unused bindings with anonymous binding in lower/testdata. #6479
+721
−698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danakj
reviewed
Dec 9, 2025
Contributor
danakj
left a comment
danakj
left a comment
There was a problem hiding this comment.
Thanks, this looks good, just a few suggestions to keep the srtucture of tests/reduce additional names
danakj
reviewed
Dec 9, 2025
danakj
approved these changes
Dec 9, 2025
| fn M() -> i32 { | ||
| var n: i32 = 0; | ||
| var m: i32; | ||
|
|
Contributor
There was a problem hiding this comment.
Restoring this newline should reduce the amount of changes in the semir
burakemir
force-pushed
the
unused_pattern_update_lower
branch
from
48c0b17 to
3744cb3
Compare
Contributor
Author
|
As discussed, pulled changes from trunk (with --rebase). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates lower/testdata to use _ instead of proper names, in order to avoid the "unused binding" warnings from #2022 which are being implemented. These changes do not depend on the implementation which should make everything easier to review.
See #6460 with part 1 of the implementation. It was split upon request in order to make reviewing easier, the original state of the PR was updating hundreds of test cases.
The PR has thus been split, part 2 including test cases changes can be viewed at https://github.com/burakemir/carbon-lang/tree/unused_pattern_bindings_p2022_impl_part2 ... many tests need to be updated, so it seems best to get those tests out of the way that are not interesting.
These are not all tests in lower/testdata - a few of them are interesting in the sense that they cannot use '_' because it leads to failed redeclaration check. This is exactly the scenario described in #3763 which requires the 'unused' marker. Those are left untouched here but are updated in https://github.com/burakemir/carbon-lang/tree/unused_pattern_bindings_p2022_impl_part2