docker-compose.yml

services:
  php:
    build:
      context: .
      args:
        PHP_MODE: production
    restart: unless-stopped
    volumes:
      - ./:/var/www/html
    depends_on:
      - redis-node-0
      - redis-node-1
      - redis-node-2
      - redis-node-3
      - redis-node-4
      - redis-node-5

  redis-node-0:
    image: bitnami/redis-cluster:latest
    restart: unless-stopped
    environment:
      ALLOW_EMPTY_PASSWORD: yes
      REDIS_CLUSTER_CREATOR: yes
      REDIS_CLUSTER_REPLICAS: 1
      REDIS_NODES: redis-node-0 redis-node-1 redis-node-2 redis-node-3 redis-node-4 redis-node-5
    depends_on:
      - redis-node-1
      - redis-node-2
      - redis-node-3
      - redis-node-4
      - redis-node-5

  redis-node-1:
    image: bitnami/redis-cluster:latest
    restart: unless-stopped
    environment:
      ALLOW_EMPTY_PASSWORD: yes
      REDIS_NODES: redis-node-0 redis-node-1 redis-node-2 redis-node-3 redis-node-4 redis-node-5

  redis-node-2:
    image: bitnami/redis-cluster:latest
    restart: unless-stopped
    environment:
      ALLOW_EMPTY_PASSWORD: yes
      REDIS_NODES: redis-node-0 redis-node-1 redis-node-2 redis-node-3 redis-node-4 redis-node-5

  redis-node-3:
    image: bitnami/redis-cluster:latest
    restart: unless-stopped
    environment:
      ALLOW_EMPTY_PASSWORD: yes
      REDIS_NODES: redis-node-0 redis-node-1 redis-node-2 redis-node-3 redis-node-4 redis-node-5

  redis-node-4:
    image: bitnami/redis-cluster:latest
    restart: unless-stopped
    environment:
      ALLOW_EMPTY_PASSWORD: yes
      REDIS_NODES: redis-node-0 redis-node-1 redis-node-2 redis-node-3 redis-node-4 redis-node-5

  redis-node-5:
    image: bitnami/redis-cluster:latest
    restart: unless-stopped
    environment:
      ALLOW_EMPTY_PASSWORD: yes
      REDIS_NODES: redis-node-0 redis-node-1 redis-node-2 redis-node-3 redis-node-4 redis-node-5

Edit:
The tests are locked to use specific ip's so the yml maybe should have ip's defined like this.

    networks:
      redis-cluster-net:
        ipv4_address: 172.18.0.7

You can run composer cs-fix to automatically fix the codestyle errors which are present.
To check if codestyle is green, you can do composer cs-check

For stan you need to do a composer stan-setup (you need to have phive installed) and then a composer stan to locally debug and fix the PHPStan/Psalm issues.

Certain stan issues can't be fixed easily, so it may be, that you need to regenerate the baselines for phpstan and psalm composer phpstan-baseline and psalm-baseline

I think the changes to RedisEngine seem good, need to add/update the tests now.

Tests have been updated. There is a separated test for RedisCluster. The main problem with the current version of that test is that it uses static ips. Im not sure how to implement RedisCluster testing to Github actions

ping @zunnu Anything left to be done? There seems to be a few conflicts.

I merged #18721 changes into 5.next So if you rebase should be on latest changes then.

Should be good now.

Error: Ignored error pattern #^Comparison operation ">" between (int<0, max>|Redis|false) and 0 results in an error.$# in path /home/runner/work/cakephp/cakephp/src/Cache/Engine/RedisEngine.php was not matched in reported errors.
Error: Ignored error pattern #^Comparison operation ">" between (int|Redis|false) and 0 results in an error.$# in path /home/runner/work/cakephp/cakephp/src/Cache/Engine/RedisEngine.php was not matched in reported errors.
Error: Process completed with exit code 1.

Error: Ignored error pattern #^Comparison operation ">" between (int<0, max>|Redis|false) and 0 results in an error.$# in path /home/runner/work/cakephp/cakephp/src/Cache/Engine/RedisEngine.php was not matched in reported errors. Error: Ignored error pattern #^Comparison operation ">" between (int|Redis|false) and 0 results in an error.$# in path /home/runner/work/cakephp/cakephp/src/Cache/Engine/RedisEngine.php was not matched in reported errors. Error: Process completed with exit code 1.

@dereuromark Done

@dereuromark Anything else to be done or can this be merged?

I wonder what those test fails are

@markstory can maybe sign off.

@dereuromark seems its related to a PHPUnit change since the 2 collection objects are not "equal" anymore.
I'll get that fixed in a separate PR.

The split package stan issues can be ignored.

ping @zunnu

@nicosp If you are happy with it we can move forward now.