Skip to content

Conversation

@Harfusha
Copy link
Contributor

No description provided.

@Harfusha
Copy link
Contributor Author

#17865

@ADmad
Copy link
Member

ADmad commented Sep 13, 2024

I am not in favor of adding rector as a dev dependency, nor running rector as a part of CI, that's wasteful.

These pedantic opioniated changes don't fix any actual problem nor bring any significant performance gains.

We can instead have a separate workflow which runs on a weekly basis and reports the diff or auto create a PR which we can review.

@dereuromark
Copy link
Member

We can also just composer require it at runtime directly inside the job.
Thats probably best.

@ADmad ADmad added this to the 5.1.0 milestone Sep 13, 2024
@othercorey
Copy link
Member

I would agree that rector is not our coding standard. We don't need another large static analyzer running on each commit.

@markstory markstory modified the milestones: 5.1.0, 5.1.1 Sep 14, 2024
@markstory markstory modified the milestones: 5.1.1, 5.1.2 Oct 4, 2024
@markstory markstory modified the milestones: 5.1.2, 5.1.3 Nov 10, 2024
@dereuromark
Copy link
Member

Do you want to refactor similar to other analyzer tasks to run only in ci? Without modifications to Code base?

@markstory markstory modified the milestones: 5.1.3, 5.1.4 Dec 13, 2024
@dereuromark
Copy link
Member

ping @Harfusha

@Harfusha
Copy link
Contributor Author

Harfusha commented Jan 6, 2025

Sorry i dont have any time right now. I will look into this issue when i find some free time

@markstory markstory modified the milestones: 5.1.5, 5.1.6 Jan 17, 2025
@markstory markstory modified the milestones: 5.1.6, 5.1.7 Feb 23, 2025
@markstory markstory modified the milestones: 5.1.7, 5.2.1 Mar 29, 2025
@markstory markstory modified the milestones: 5.2.1, 5.2.2 Apr 6, 2025
@markstory markstory modified the milestones: 5.2.2, 5.2.3 Apr 18, 2025
@markstory markstory added this to the 5.2.4 milestone Apr 24, 2025
@dereuromark dereuromark mentioned this pull request May 5, 2025
@dereuromark
Copy link
Member

#18625

@dereuromark dereuromark closed this May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants