-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Install rector, add rector config, add rector changes, add rector for CI #17900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I am not in favor of adding rector as a dev dependency, nor running rector as a part of CI, that's wasteful. These pedantic opioniated changes don't fix any actual problem nor bring any significant performance gains. We can instead have a separate workflow which runs on a weekly basis and reports the diff or auto create a PR which we can review. |
|
We can also just composer require it at runtime directly inside the job. |
|
I would agree that rector is not our coding standard. We don't need another large static analyzer running on each commit. |
|
Do you want to refactor similar to other analyzer tasks to run only in ci? Without modifications to Code base? |
|
ping @Harfusha |
|
Sorry i dont have any time right now. I will look into this issue when i find some free time |
No description provided.