Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform arrow functions to fix #47 #49

Closed
wants to merge 2 commits into from

Conversation

paulr113
Copy link

No description provided.

@OsamaAbbas
Copy link
Collaborator

OsamaAbbas commented Feb 2, 2020

Thank you for this pull request.

Unfortunately, depending on Babel is the very opposite to what "minimalistic" word means. Comparing paulr113/bytenode: "1,744 items (and 11 hidden), totalling 6.7 MB" with OsamaAbbas/bytenode: "5 items, totalling 19.3 kB" is enough for me to refuse depending on Babel and the loads of packages it requires.

You solution can be implemented in another layer, either in a separate project or using webpack (check this plugin).

Thank you again, I really appreciate your effort.

@OsamaAbbas OsamaAbbas closed this Feb 3, 2020
@notpushkin
Copy link

Maybe adding a simplified transform code (e. g. based on Bublé's arrow transform) would be a feasible option here? That would still add a couple dozen kB for the parser but should not be as bad as depending on Babel.

@OsamaAbbas
Copy link
Collaborator

Maybe adding a simplified transform code (e. g. based on Bublé's arrow transform) would be a feasible option here? That would still add a couple dozen kB for the parser but should not be as bad as depending on Babel.

As I said, these solutions can be implemented in another layer. There is no need to be done in bytenode itself. I believe that this narrow focus benefits the project. Also, that arrow issue lies in fact in either Node.js, Electron or v8 (which is more likely), so it should be reported there to get fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants