Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated node version for github actions #1562

Merged
merged 5 commits into from
May 19, 2023
Merged

updated node version for github actions #1562

merged 5 commits into from
May 19, 2023

Conversation

SaumyaBhushan
Copy link
Contributor

@SaumyaBhushan SaumyaBhushan commented Nov 28, 2022 •
edited
Loading

workerB
Signed-off-by: SaumyaBhushan [email protected]

Summary

updated node version for github actions

Output

Before

Node 12

After

Node 16

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

#1561
Resolves #1561

@SaumyaBhushan SaumyaBhushan requested review from a team as code owners November 28, 2022 05:42
@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Nov 28, 2022
@github-actions github-actions bot added this to the 0.28.0 milestone Nov 28, 2022
@SaumyaBhushan
Copy link
Contributor Author

Hi @samj1912 Can you please review this one as well?

@sambhav
Copy link
Member

sambhav commented Nov 29, 2022

@SaumyaBhushan did you have a chance to test this and see if it works with node16?

@SaumyaBhushan
Copy link
Contributor Author

SaumyaBhushan commented Nov 30, 2022 •
edited
Loading

@SaumyaBhushan did you have a chance to test this and see if it works with node16?

No I have not @samj1912

SaumyaBhushan
SaumyaBhushan commented Dec 1, 2022
View reviewed changes
Copy link
Contributor Author

@SaumyaBhushan SaumyaBhushan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@dfreilich dfreilich modified the milestones: 0.28.0, 0.29.0 Jan 8, 2023
@dfreilich
updated node version
5f23ec6 
Signed-off-by: SaumyaBhushan <[email protected]>
@codecov
Copy link

codecov bot commented Feb 8, 2023 •
edited
Loading

Codecov Report

Merging #1562 (92c61db) into main (0a19002) will increase coverage by 0.63%.
The diff coverage is n/a.

❗ Current head 92c61db differs from pull request most recent head 2e7e1da. Consider uploading reports for the commit 2e7e1da to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1562      +/-   ##
==========================================
+ Coverage   80.52%   81.14%   +0.63%     
==========================================
  Files         163      156       -7     
  Lines       10740    10362     -378     
==========================================
- Hits         8647     8407     -240     
+ Misses       1576     1458     -118     
+ Partials      517      497      -20
Flag Coverage Δ
os_linux 79.93% <ø> (+0.61%) ⬆️
os_macos 77.45% <ø> (+0.04%) ⬆️
os_windows 80.29% <ø> (-0.13%) ⬇️
unit 81.14% <ø> (+0.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

dfreilich
dfreilich approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@dfreilich dfreilich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help!

Validated here: #1561 (comment)

@SaumyaBhushan
Copy link
Contributor Author

Hi @dfreilich Are we planning to merge this one or do we need to change something here ?

@dfreilich dfreilich modified the milestones: 0.29.0, 0.30.0 Mar 26, 2023
@natalieparellano
Copy link
Member

The previous CI failures appear to be flakes. Hopefully this goes green with the latest updates from main

@dfreilich dfreilich merged commit 8d55b54 into buildpacks:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sambhav sambhav sambhav approved these changes

@dfreilich dfreilich dfreilich approved these changes

Assignees
No one assigned
Labels
type/chore Issue that requests non-user facing changes.
Projects
None yet
Milestone
0.30.0
Development

Successfully merging this pull request may close these issues.

Update Release Notes to use Node v16
4 participants
@SaumyaBhushan @sambhav @natalieparellano @dfreilich