Don't set state to not-ready if the ready prop is true #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered a bug with the
delay
prop which would result in the placeholder showing indefinitely, with{ready: true}
in props but{ready: false}
in state.I believe the events which lead to this are, when delay is set to n milliseconds, all of the following happen before n milliseconds is up:
ready
prop is set to false, a timeout to setready
state is set and the ID stored inthis.timeout
props.children
is changed, causecomponentWillReceiveProps
to be called again; this causes another timeout to setready
state to be created, and the ID stored inthis.timeout
is overwrittenready
prop is set to true, which sets state to{ready: true}
and which also deletes the timeout set in step 2 (but, crucially, not the timeout set in step 1){ready: false}
The pull request is one approach among many to fix this. You could also clear any existing timeout in
this.timeout
before setting a new one, or change the render method toThanks!