Load configuration from Plist files #582
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Allows loading of Configuration from Plist files, without creating a configuration object up front in code.
Changeset
BugsnagConfiguration.loadConfig()
method, which reads from the main bundle's plist. Note that the naming is a required deviation from the spec due to an existing method onNSObject
BSGConfigurationBuilder
which loads configuration options from the plist under the 'bugsnag' keyBugsnagConfiguration
to set theapiKey
property to an empty string if it is not a valid value or a string value. Previous behaviour was to keep it as the passed in value, even if the object was of a different type (such as a dictionary)Reads the following values:
Tests