Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move codeBundleId from configuration to non-public client property #548

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Move codeBundleId from configuration to non-public client property #548

merged 1 commit into from
Apr 22, 2020

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Apr 20, 2020 •
edited
Loading

Goal

Removes the codeBundleId from the public API and onto BugsnagClient. This is because end-users do not need to set the value - it is required only for the React Native implementation, where it is set via JS.

Changeset

  • Removed codeBundleId property from BugsnagConfiguration
  • Updated Bugsnag to set codeBundleId on BugsnagClient rather than BugsnagConfiguration
  • BugsnagApp and BugsnagAppWithState now have constructor parameter for codeBundleId rather than relying on BugsnagConfiguration
  • Added custom setter on BugsnagClient so that when codeBundleId is set, the value is propagated to events + sessions
  • Recorded app.codeBundleId value when an OOM is detected

Tests

Updated existing test coverage to supply codeBundleId from Client rather than Configuration

@fractalwrench fractalwrench force-pushed the v6-codebundle-removal branch 3 times, most recently from 5e02238 to 3272997 Compare April 20, 2020 14:34
@fractalwrench fractalwrench marked this pull request as ready for review April 20, 2020 14:35
@fractalwrench fractalwrench force-pushed the v6-codebundle-removal branch from 3272997 to 8358b11 Compare April 21, 2020 11:36
robinmacharg
robinmacharg approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@robinmacharg robinmacharg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good set of changes; couldn't see anything missing.

@fractalwrench fractalwrench force-pushed the v6-codebundle-removal branch from 8358b11 to 869915d Compare April 22, 2020 11:53
@fractalwrench fractalwrench merged commit 9debaf5 into v6 Apr 22, 2020
@fractalwrench fractalwrench deleted the v6-codebundle-removal branch April 22, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinmacharg robinmacharg robinmacharg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fractalwrench @robinmacharg