Convert event.app from NSDictionary to a structured class #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
changed the title
fractalwrench
changed the title
fractalwrench
force-pushed
the
v6-structured-app
branch
3 times, most recently
from
ae67b46 to
554956a
Compare
fractalwrench
force-pushed
the
v6-structured-app
branch
from
554956a to
6638699
Compare
robinmacharg
reviewed
Apr 3, 2020
robinmacharg
reviewed
Apr 3, 2020
robinmacharg
reviewed
Apr 3, 2020
robinmacharg
reviewed
Apr 3, 2020
robinmacharg
reviewed
Apr 3, 2020
robinmacharg
reviewed
Apr 3, 2020
robinmacharg
reviewed
Apr 3, 2020
robinmacharg
reviewed
Apr 3, 2020
robinmacharg
reviewed
Apr 3, 2020
robinmacharg
reviewed
Apr 3, 2020
robinmacharg
reviewed
Apr 3, 2020
robinmacharg
reviewed
Apr 3, 2020
robinmacharg
suggested changes
Apr 3, 2020
There was a problem hiding this comment.
From what I understand, looks good. And 68% coverage on unit tests, which is definitely going in the right direction! Couple of in-line comments, mostly opinionated nits over formatting.
Is it worth putting new structured containers in a group in XCode to make working with them easier? Assuming that the podspec needs updated to match any folder nesting. The list of files is now considerable (i.e. more than a screen-full). Failing that the new additions should be arranged alphabetically in XCode.
This is definitely worth doing - I'll raise a separate PR to address this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Converts
event.appfrom anNSDictionaryto a structured class where each field is represented as a property.BugsnagAppis used for sessions, and contains stateless properties that do not change over the lifecycle of an application.BugsnagAppWithStateextends this class and is used for events, and contains stateful properties that change for each error - e.g. durationInForeground.Changeset
BugsnagAppandBugsnagAppWithStateclasses with properties for each field in the specBugsnagConfigurationto have a default value forappType, rather than parsing in theBugsnagEventBugsnagEventto use readonlyBugsnagAppWithStateforevent.appBSGParseAppandBSGParseAppWithStatemethods into newBugsnagAppclasses, so that they can parse a KSCrash report and populate their fieldsBugsnagApp/WithStatefromBugsnagEventapp.nameas it is the same asapp.idTests
BugsnagAppandBugsnagAppWithStatepopulate correctly, and that they serialize JSON correctly