Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename Bugsnag.clearTab to Bugsnag.ClearMetadata #457

Closed
wants to merge 7 commits into from
Closed

refactor: rename Bugsnag.clearTab to Bugsnag.ClearMetadata #457

wants to merge 7 commits into from

Conversation

robinmacharg
Copy link
Contributor

Goal

Simple refactoring of a method to align it with other notifiers.

Design

Simple search/replace along with Unit and CI checks.

Changeset

M	CHANGELOG.md
M	Source/Bugsnag.h
M	Source/Bugsnag.m
M	Source/BugsnagMetadata.h
M	Source/BugsnagMetadata.m
M	iOS/BugsnagTests/Swift Tests/BugsnagSwiftTests.swift

Tests

Added a single additional Swift test to check that the name is exposed correctly.

Review

Outstanding Questions

  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review
  • The correct target branch has been selected (master for fixes, next for
    features)
  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

kattrali and others added 6 commits January 24, 2020 09:31
@kattrali
feat: Add a breadcrumb when the library starts (#445)
412006e
@kattrali
ci: Fix build on Xcode 10 for swift tests
c948695 
Adding swift has broken the Xcode 10.2 env, fix by creating a dir
https://stackoverflow.com/questions/55389080/
@robinmacharg
refactor: rename BugsnagCrashReport to BugsnagEvent (#449)
00b7a09
@robinmacharg
feat(spec): Added designated initializer to BugsnagConfiguration (#446)
6c74bfb 
Co-Authored-By: Delisa <[email protected]>

* Added designated initializer to BugsnagConfiguration.  Designated initializer is Swift-throws-friendly, and exposed correctly via NS_SWIFT_NAME.

* Made convenience init() non-functional.

* Updated ObjC tests, added Swift test

* Early-merged some additional bits and pieces that got rolled in during CI fixes.  incl.  Rename-BugsnagCrashReport-to-BugsnagEvent, added .md files to project to make updates simpler. Add a breadcrumb when the library starts (#445)

* Updates to .gitignore to exclude IDEWorkspaceChecks.plist

* CI: Fix build on Xcode 10 for swift tests.  Adding Swift has broken the Xcode 10.2 env, fix by creating a dir (https://stackoverflow.com/questions/55389080/).  Update CI tests to account for mandatory API_KEY.
@robinmacharg
refactor: Rename "metaData" to "metadata" (#450)
89a4eb1
@robinmacharg
refactor: rename Bugsnag.addAttribute to addMetadata, add tests
138d1b9
@robinmacharg robinmacharg force-pushed the robinmacharg/rename-cleartab-to-clearmetadata branch from 3d2f667 to 898f63b Compare February 6, 2020 11:35
@robinmacharg robinmacharg force-pushed the robinmacharg/rename-cleartab-to-clearmetadata branch from 898f63b to 30b26b7 Compare February 6, 2020 11:53
@kattrali kattrali closed this Feb 25, 2020
@twometresteve twometresteve deleted the robinmacharg/rename-cleartab-to-clearmetadata branch June 8, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattrali kattrali Awaiting requested review from kattrali

@fractalwrench fractalwrench Awaiting requested review from fractalwrench

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robinmacharg @kattrali