Add Device time of report capture to JSON payload #315
Conversation
fractalwrench
changed the title
features/handled_errors.feature
Outdated
| @@ -6,6 +6,7 @@ Scenario: Override errorClass and message from a notifyError() callback | |||
| And the request is a valid for the error reporting API | |||
| And the exception "errorClass" equals "Bar" | |||
| And the exception "message" equals "Foo" | |||
| And the payload field "events.0.device.time" is not null | |||
There was a problem hiding this comment.
I would like to verify the format of this field and also that it is the current time.
|
I have updated the mazerunner scenario to check that the field is a timestamp. There's also some coverage in the unit tests for ensuring the timestamp is serialised from the KSCrash field, if that's sufficient? Note: Cocoa mazerunner scenarios still do not work on my machine and this makes it very hard to write/debug scenarios. |
|
It doesnt look like any tests test that the timestamp is the right time (i.e. within 5 seconds of now). |
|
I have updated the mazerunner scenario to check that the field is a timestamp within 30s of the current time . |
features/steps/ios_steps.rb
Outdated
| Then("the event {string} is within {int} ms of the current timestamp") do |field, threshold_ms| | ||
| value = read_key_path(find_request(0)[:body], "events.0.#{field}") | ||
| assert_not_nil(value, "Expected a timestamp") | ||
| nowMs = Time.now.to_i |
There was a problem hiding this comment.
These are actually seconds so all these times should be updated to be seconds, and the thresholds in tests should be seconds.
features/steps/ios_steps.rb
Outdated
| @@ -1,3 +1,5 @@ | |||
| require 'date' | |||
There was a problem hiding this comment.
You dont use this require.
Goal
Reports may be cached on a device if no network connection is available. In this case, the report may not be delivered for hours, or even days, after the error was originally captured by Bugsnag.
Sending the time at which the report was originally captured allows for timestamps to be normalised. This avoids confusing information similar to the following being shown:
Design
The pipeline normalises timestamps based off the
device.timefield.Changeset
Serialises the time at which the report was generated into the
device.timepayload field.Tests
device.timein handled/unhandled errorReview
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: