handle unknown CPU archs, improve error messaging #235

kattrali · 2018-01-23T22:11:12Z

The register parser handling made assumptions about there always being a CPU arch match for the registry being parsed. These changes:

Handle unknown architectures gracefully
Add support for missing architectures (x64 by @paulz)
Fix support for arm64 (register names were incorrect)
Fix detection of Swift assertions (message contents changed in Swift 4)
Improve formatting of Swift assertion messages to indicate the assertion type in the error class

update expected cpu arch

The notable register names on arm64 is x{0-3}

Its internally unused and not needed externally

Makes customized error class/message available during callbacks

Paul Zabelin and others added 10 commits January 23, 2018 11:41

fix crash while reporting user exception

85402f0

update expected cpu arch

Handle case where register name is nil

4bdf291

Add register names for arm64

cea348b

The notable register names on arm64 is x{0-3}

Make reserved word checks case-insensitive

add71b3

swiftlang/swift@d03a575

Populate error class from register data

752cd2f

Deprecate enhancedErrorMessageForThread

088db49

Its internally unused and not needed externally

Process thread error message during initialization

1bec976

Makes customized error class/message available during callbacks

Fix file references in test targets for tvOS, macOS

5fd7e3f

Avoid check before ensuring string value

15906ac

handle preconditionFailed

9ab2c16

kattrali merged commit a1e3f76 into master Jan 24, 2018

kattrali deleted the kattrali/handle-unknown-arch branch January 24, 2018 01:43

Provide feedback