[PLAT-8863] Fix crash when reporting internal errors during +[Bugsnag start]
#1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generated by 🚫 Danger |
kstenerud
approved these changes
Sep 1, 2022
tomlongridge
reviewed
Sep 1, 2022
| if (self.configuration.telemetry & BSGTelemetryInternalErrors) { | ||
| BSGInternalErrorReporter.sharedInstance = [[BSGInternalErrorReporter alloc] initWithDataSource:self]; | ||
| } else { | ||
| bsg_log_debug(@"Internal error reporting was disable in config"); |
There was a problem hiding this comment.
Minor (pre-existing) typo, probably not worth a CI re-run unless you have other changes:
Suggested change
| bsg_log_debug(@"Internal error reporting was disable in config"); | |
| bsg_log_debug(@"Internal error reporting was disabled in config"); |
There was a problem hiding this comment.
Will fix in the release 👍
This was referenced Sep 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix a crash that could occur when reporting internal errors during
+[Bugsnag start].Regression introduced in #1435 / v6.21.0
Changeset
Initializes
BSGInternalErrorReporterAFTERbsg_runContextto ensure the latter is non-null.Considered moving
BSGRunContextInitto a+initializemethod instead, but that would hinder testing - it would not be possible to setbsg_runContexttoNULLand have it re-initialized when starting a newBugsnagClient.Testing
Adds a unit test case that reproduced the problem and verifies the fix.