Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAT-8703] access feature flags #1432

Merged
merged 2 commits into from
Jul 13, 2022
Merged

[PLAT-8703] access feature flags #1432

merged 2 commits into from
Jul 13, 2022

Conversation

kstenerud
Copy link
Contributor

Goal

Allow the active feature flags to be accessed from the onSend callback

Testing

Added e2e scenario

@kstenerud kstenerud force-pushed the PLAT-8703-access-feature-flags branch from ba3fd5e to b62e815 Compare July 12, 2022 14:23
@github-actions
Copy link

github-actions bot commented Jul 12, 2022 •
edited
Loading

Bugsnag.framework binary size increased by 136 bytes from 814,400 to 814,536

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%     +80  +0.1%     +80    Symbol Table
  +0.0%     +76  +0.0%     +76    __TEXT,__text
  +0.0%     +56  +0.0%     +56    String Table
  +0.1%     +40  +0.1%     +40    __DATA,__objc_const
  +0.0%     +13  +0.0%     +13    __TEXT,__objc_methname
  -0.5%     -40  -0.3%     -40    [__DATA]
  -0.4%     -89  -0.4%     -89    [__TEXT]
  [ = ]       0  -2.8%    -136    [__LINKEDIT]
  +0.0%    +136  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud force-pushed the PLAT-8703-access-feature-flags branch from b62e815 to 3692108 Compare July 12, 2022 14:25
@kstenerud kstenerud marked this pull request as ready for review July 12, 2022 14:25
@kstenerud kstenerud requested review from nickdowell and kattrali July 12, 2022 14:25
nickdowell
nickdowell suggested changes Jul 12, 2022
View reviewed changes
Bugsnag/Payload/BugsnagEvent.m Outdated Show resolved Hide resolved
@kstenerud kstenerud requested a review from nickdowell July 12, 2022 14:38
@kstenerud kstenerud merged commit 2a5d390 into next Jul 13, 2022
@kstenerud kstenerud deleted the PLAT-8703-access-feature-flags branch July 13, 2022 07:09
@nickdowell nickdowell mentioned this pull request Jul 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickdowell nickdowell nickdowell approved these changes

@kattrali kattrali Awaiting requested review from kattrali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kstenerud @nickdowell