[PLAT-8614] Prevent reporting of OOMs on simulators #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
kstenerud
approved these changes
Jun 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Prevent reporting of (false positive) OOMs on simulators.
Apps running in the simulator are not killed by the system in response to memory warnings. OOMs reported from the simulator are therefore most likely to be due to the app being killed by Xcode when running without a debugger attached, and it does not make sense to report these.
Changeset
BSG_HAVE_OOM_DETECTIONnow evaluates to 0 when building for simulators.Testing
Verified using local test app. E2E tests on CI verify that OOM reporting still works on real devices.