[PLAT-7986] Ignore non-fatal SIGPIPEs #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generated by 🚫 Danger |
nickdowell
force-pushed
the
nickdowell/sigpipe-ignore
branch
from
1575042 to
4cc4934
Compare
kstenerud
approved these changes
Feb 15, 2022
| @@ -212,6 +212,11 @@ bool bsg_kscrashsentry_installSignalHandler( | |||
| } | |||
| goto failed; | |||
| } | |||
| if (fatalSignals[i] == SIGPIPE && | |||
There was a problem hiding this comment.
I wonder if maybe we should check for SIG_IGN on all signals except KILL and STOP (which can't be ignored).
There was a problem hiding this comment.
Yes that might be worth a follow-up 👍
kattrali
approved these changes
Feb 15, 2022
nickdowell
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Stop reporting false
SIGPIPEunhandled errors when ignored withSIG_IGN.If an app uses
sigignore(SIGPIPE)orsignal(SIGPIPE, SIG_IGN)then when aSIGPIPEis raised, the process will not be terminated.Bugsnag's hander assumes that the signal will be fatal and writes a crash report.
Changeset
Removes Bugsnag's signal handler for
SIGPIPEif the previously configured handler wasSIG_IGN.Testing
Adds an E2E scenario that was able to reproduce the problem and verify the fix.
Updates SIGPIPEScenario to use a more realistic method to trigger a SIGPIPE.