[PLAT-7396] Redact breadcrumb metadata #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdowell
changed the title
kstenerud
requested changes
Oct 8, 2021
nickdowell
force-pushed
the
nickdowell/redacted-keys-for-breadcrumbs
branch
from
2f7f0c4 to
86e82eb
Compare
kstenerud
approved these changes
Oct 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Apply
redactedKeysto breadcrumb metadata.Changeset
BugsnagEvent's
-serializeBreadcrumbshas been renamed to-serializeBreadcrumbsWithRedactedKeys:and now uses the same redaction logic applied to event metadata.Methods that implement redaction have been renamed for clarity.
Testing
Added unit test case to verify that breabcrumb metadata is redacted when serialized as part of an event.
Amended network breadcrumb E2E scenario to verify that
urlParamsare redacted.Ran the test locally using
make e2e_macos FEATURES=features/breadcrumbs.feature:58