Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAT-6990] Fix ThreadSanitizer data race warning in BSGAppHangDetector #1153

Merged
merged 2 commits into from
Jul 14, 2021
Merged

[PLAT-6990] Fix ThreadSanitizer data race warning in BSGAppHangDetector #1153

merged 2 commits into from
Jul 14, 2021

Conversation

nickdowell
Copy link
Contributor

Goal

To fix data race detected by ThreadSanitizer

WARNING: ThreadSanitizer: data race (pid=96119)
  Write of size 8 at 0x7b10000ab9e0 by main thread:
    #0 -[BSGAppHangDetector setProcessingDeadline:] BSGAppHangDetector.m (Bugsnag Test App:x86_64+0x1000353a9)
    #1 __40-[BSGAppHangDetector startWithDelegate:]_block_invoke BSGAppHangDetector.m:76 (Bugsnag Test App:x86_64+0x100033def)
    #2 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ <null>:2 (CoreFoundation:x86_64+0x9eeb6)
    #3 start <null>:2 (libdyld.dylib:x86_64+0xcf4)

  Previous read of size 8 at 0x7b10000ab9e0 by thread T7:
    #0 -[BSGAppHangDetector processingDeadline] BSGAppHangDetector.m:27 (Bugsnag Test App:x86_64+0x100035325)
    #1 -[BSGAppHangDetector detectAppHangs] BSGAppHangDetector.m:119 (Bugsnag Test App:x86_64+0x10003445b)
    #2 __NSThread__start__ <null>:2 (Foundation:x86_64+0xc90ec)

  Location is heap block of size 64 at 0x7b10000ab9c0 allocated by main thread:
    #0 calloc <null>:2 (libclang_rt.tsan_iossim_dynamic.dylib:x86_64+0x4e852)
    #1 _objc_rootAllocWithZone <null>:2 (libobjc.A.dylib:x86_64+0x14072)
    #2 -[BugsnagClient start] BugsnagClient.m:417 (Bugsnag Test App:x86_64+0x100067e05)
    #3 +[Bugsnag startWithConfiguration:] Bugsnag.m:61 (Bugsnag Test App:x86_64+0x1000510aa)
    #4 +[Bugsnag start] Bugsnag.m:48 (Bugsnag Test App:x86_64+0x100050cf6)
    #5 -[AppDelegate application:didFinishLaunchingWithOptions:] AppDelegate.m:21 (Bugsnag Test App:x86_64+0x1000035da)
    #6 -[UIApplication _handleDelegateCallbacksWithOptions:isSuspended:restoreState:] <null>:2 (UIKitCore:x86_64+0xa8694e)
    #7 start <null>:2 (libdyld.dylib:x86_64+0xcf4)

  Thread T7 (tid=2230994, running) created by main thread at:
    #0 pthread_create <null>:2 (libclang_rt.tsan_iossim_dynamic.dylib:x86_64+0x2aa1d)
    #1 -[NSThread start] <null>:2 (Foundation:x86_64+0xc8c4d)
    #2 -[BugsnagClient startAppHangDetector] BugsnagClient.m:1202 (Bugsnag Test App:x86_64+0x100074ddb)
    #3 -[BugsnagClient start] BugsnagClient.m:417 (Bugsnag Test App:x86_64+0x100067e05)
    #4 +[Bugsnag startWithConfiguration:] Bugsnag.m:61 (Bugsnag Test App:x86_64+0x1000510aa)
    #5 +[Bugsnag start] Bugsnag.m:48 (Bugsnag Test App:x86_64+0x100050cf6)
    #6 -[AppDelegate application:didFinishLaunchingWithOptions:] AppDelegate.m:21 (Bugsnag Test App:x86_64+0x1000035da)
    #7 -[UIApplication _handleDelegateCallbacksWithOptions:isSuspended:restoreState:] <null>:2 (UIKitCore:x86_64+0xa8694e)
    #8 start <null>:2 (libdyld.dylib:x86_64+0xcf4)

SUMMARY: ThreadSanitizer: data race BSGAppHangDetector.m in -[BSGAppHangDetector setProcessingDeadline:]

Changeset

Make processingDeadline atomic to fix data race.

Testing

Reproduced issue by enabling Thread Sanitizer in example app.

@github-actions
Copy link

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size did not change - 1,133,880 bytes

Generated by 🚫 Danger

@nickdowell nickdowell merged commit 51e21c1 into next Jul 14, 2021
@nickdowell nickdowell deleted the nickdowell/fix-tsan-warning branch July 14, 2021 09:10
@nickdowell nickdowell mentioned this pull request Jul 14, 2021
Merged
@djskinner djskinner mentioned this pull request Jul 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlongridge tomlongridge tomlongridge approved these changes

@kattrali kattrali kattrali approved these changes

@kstenerud kstenerud Awaiting requested review from kstenerud kstenerud is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickdowell @kattrali @tomlongridge