[PLAT-6536] Disable Cocoapods prefix header and enable additional warnings #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
approved these changes
May 13, 2021
| # Include all our build warning settings without needing to duplicate them here | ||
| xcconfig = "Pods/Target Support Files/#{target.name}/#{target.name}.#{config.name.downcase}.xcconfig" | ||
| File.open(xcconfig, 'a') do |file| | ||
| file << '#include "../../../../../../Bugsnag.xcconfig"' |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Disable the prefix header created by Cocoapods. Sometimes different warnings would appear in Cocoapods builds because of the prefix header force-including UIKit on iOS, so removing it makes the builds more consistent.
Enable additional warnings when building the iOS fixture app (which uses Cocoapods to integrate Bugsnag) so that we are alerted of any build warnings that only appear there.
Changeset
The main
Bugsnag.xcconfigis included by the test fixture when building Bugsnag so that the same warnings settings are applied.A build warning was fixed that was only appearing when
BSG_LOG_LEVELwas set toBSG_LOGLEVEL_DEBUGTesting
Tested via unit and E2E tests.