[PLAT-6433] Additional compiler warnings #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Enable additional compiler warnings to detect potential issues in our code, and address any warnings raised.
Changeset
Refactors
Bugsnag.xcconfigto use Xcode's warning build settings instead of raw compiler flags where available.Enables the following additional warnings and fixes warnings raised:
-Wcast-qual-Wcustom-atomic-properties-Wdirect-ivar-access-Wdocumentation-unknown-command-Wformat-nonliteral-Widiomatic-parentheses-Wimport-preprocessor-directive-pedantic-Wmissing-variable-declarations-Woverriding-method-mismatch-Wswitch-enum-Wunused-macrosThe xcconfig is no longer applied to the unit test targets in order to avoid excessive warnings there. Some unit test code would by design result in build warnings due to testing edge cases & invalid arguments.
Testing
Tested by running unit tests locally, and unit & E2E tests on CI.