[PLAT-4706] Fix thread sending behaviour #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdowell
force-pushed
the
nickdowell/fix-send-threads
branch
from
0b1a8e5 to
4ac28ab
Compare
nickdowell
changed the title
kattrali
approved these changes
Apr 21, 2021
Merged
This was referenced May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
To stop
threadsbeing sent if the notifier has been configured not to via thesendThreadsproperty.Prior to this change,
threadswould contain a single object.Changeset
-[BugsnagClient notify:]has been amended to send an emptythreadsarray if threads should not be sent.-[BugnagEvent initWithKSCrashData:]has been amended to send an emptythreadsarray if a single thread was captured - this is what KSCrash does when if thread sending is disabled (so that the offending stacktrace is captured.)Testing
Verified through E2E tests, and manually tested using example app.