Prevent uploads from crashing with bad JSON #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdowell
force-pushed
the
nickdowell/catch-json-exceptions
branch
from
f28d260 to
17c44b0
Compare
kattrali
approved these changes
Apr 6, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
If the metadata JSON contains non-object values at the top level, an exception will be thrown from
-[BugsnagEvent sanitiseMetadata:redactedKeys:]Changeset
-[BugsnagEvent sanitiseMetadata:redactedKeys:]now rejects top-level values that are are not dictionaries, and leaves a diagnostic showing the unexpected data.@try/@catchblocks have also been added to prevent any other exceptions from causing a crash while preparing the payload for upload.Testing
Tested locally by adding bad data to
NSMutableDictionary *metadatabefore calling-[BugsnagEvent sanitiseMetadata:redactedKeys:]