Skip to content

feat: Update google datastore sdk version and add tracing enablement flag #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
suraj-pasuparthy merged 18 commits into from
Dec 6, 2024
Merged

feat: Update google datastore sdk version and add tracing enablement flag #1734

suraj-pasuparthy merged 18 commits into from
Dec 6, 2024

Conversation

@cindy-peng
Copy link
Contributor

@cindy-peng cindy-peng commented Nov 15, 2024 •
edited
Loading

The current YCSB datastore driver runs on a very old google datastore SDK version. This PR is to:

  1. Update the datastore version from 1.1.0 to the latest version 2.24.2
  2. Modify datastore operation methods with the latest datastore SDK version
  3. Add a property projectId to datastore configuration (This was missing earlier thus projectId always incorrectly shares the same value with datasetId)
  4. Add tracingEnabled flags to google datastore configuration to enable publishing traces to Cloud Trace

@cindy-peng cindy-peng mentioned this pull request Dec 6, 2024
Closed
@suraj-pasuparthy suraj-pasuparthy merged commit ab1b823 into brianfrankcooper:master Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bvliu bvliu bvliu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cindy-peng @bvliu @suraj-pasuparthy