Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Default JQuery Path #260

Merged
merged 1 commit into from
Jun 26, 2014
Merged

Updated Default JQuery Path #260

merged 1 commit into from
Jun 26, 2014

Conversation

sprankhub
Copy link
Contributor

The defaut jQuery path should link to the current version of jQuery, which is 1.11.1 and not 1.11.0. Otherwise, I get the following error when I do a php app/console assetic:dump:

[RuntimeException]                                                                                
The source file "/var/www/roombook/app/../vendor/jquery/jquery/jquery-1.11.0.js" does not exist.

@sprankhub
Updated Default JQuery Path
9c1f6e1 
The defaut jQuery path should link to the current version of jQuery, which is `1.11.1` and not `1.11.0`. Otherwise, I get the following error when I do a `php app/console assetic:dump`:

    [RuntimeException]                                                                                
    The source file "/var/www/roombook/app/../vendor/jquery/jquery/jquery-1.11.0.js" does not exist.
@bigfoot90
Copy link
Contributor

Can I suggest another solution?

Add this to requirements in your composer.json

"components/jquery": "~2.1",

instead of

{
    "repositories": [
        {
            "type": "package",
            "package": {
                "name": "jquery/jquery",
                "version": "1.10.2",
                "dist": {
                    "url": "http://code.jquery.com/jquery-1.10.2.js",
                    "type": "file"
                }
            }
        }
    ],
    "require": {
        ... other dependencies
        "jquery/jquery":  "1.10.*"
    }
}

and then jquery path become

    jquery_path: %kernel.root_dir%/../vendor/components/jquery/jquery.min.js

@althaus
Copy link
Contributor

althaus commented Jun 25, 2014

"components/jquery": "~2.1"

The usage of components relies on RobLoach/component-installer and I wouldn't force users to this.

@bigfoot90
Copy link
Contributor

but now you are forcing users to add custom repositories or to overwrite default jquery_path.
Assetic will not compile otherwise.

florianeckerstorfer pushed a commit that referenced this pull request Jun 26, 2014
Merge pull request #260 from sprankhub/patch-1
d02f7fc 
Updated Default JQuery Path
@florianeckerstorfer florianeckerstorfer merged commit d02f7fc into braincrafted:develop Jun 26, 2014
@sprankhub sprankhub deleted the patch-1 branch June 26, 2014 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sprankhub @bigfoot90 @althaus @florianeckerstorfer