Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for LLVM 12 and below #3325

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Drop support for LLVM 12 and below #3325

merged 1 commit into from
Jul 18, 2024

Conversation

ajor
Copy link
Member

@ajor ajor commented Jul 17, 2024

LLVM 11 and below have been untested for a while.
Dropping LLVM 12 allows us to upgrade to C++ 20.

Checklist
  • [ ] Language changes are updated in man/adoc/bpftrace.adoc
  • User-visible and non-trivial changes updated in CHANGELOG.md
  • The new behaviour is covered by tests

@ajor ajor requested review from viktormalik, danobi and fbs as code owners July 17, 2024 15:10
danobi
danobi approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@danobi danobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great cleanup!

looks like clang-format needs to be fixed though

viktormalik
viktormalik approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@viktormalik viktormalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see getting rid of those ifdefs!

@ajor
Drop support for LLVM 12 and below
a6f1885 
LLVM 11 and below have been untested for a while.
Dropping LLVM 12 allows us to upgrade to C++ 20.
@ajor
Copy link
Member Author

ajor commented Jul 18, 2024

[clang-format]

@ajor ajor merged commit 70eb8c0 into bpftrace:master Jul 18, 2024
16 checks passed
@ajor ajor deleted the drop-llvm-12 branch July 18, 2024 10:00
@ajor ajor mentioned this pull request Jul 18, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktormalik viktormalik viktormalik approved these changes

@danobi danobi danobi approved these changes

@fbs fbs Awaiting requested review from fbs fbs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajor @danobi @viktormalik