Fix stack mode for stack builtin #3322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktormalik
reviewed
Jul 17, 2024
There was a problem hiding this comment.
LGTM, just one comment below.
Also, I don't think that this fixes stack mode specifically for maps or map keys. It rather fixes stack mode for kstack and ustack used as a builtin variable (i.e. without ()).
For instance, all of these are currently broken and should be fixed by this PR:
# bpftrace -e 'config = { stack_mode = raw } kprobe:vfs_read { @ = kstack; exit() }'
# bpftrace -e 'config = { stack_mode = raw } kprobe:vfs_read { @[kstack] = 0; exit() }'
# bpftrace -e 'config = { stack_mode = raw } kprobe:vfs_read { $s = kstack; print($s); exit() }'
Perhaps the tests and the commit message should be adjusted to reflect that.
Also this affects released v0.21.0 so a changelog entry would make sense here.
Yes, good call. Will update both. |
jordalgo
force-pushed
the
stack_mode_map_printing
branch
from
a9da163 to
2f6b87b
Compare
jordalgo
changed the title
viktormalik
approved these changes
Jul 17, 2024
jordalgo
force-pushed
the
stack_mode_map_printing
branch
from
2f6b87b to
1f04426
Compare
viktormalik
reviewed
Jul 17, 2024
jordalgo
force-pushed
the
stack_mode_map_printing
branch
from
1f04426 to
5780653
Compare
viktormalik
approved these changes
Jul 17, 2024
The stack mode for kstack and ustack builtin
variables (i.e. without ()) were not respecting
the stack mode value set by the config block.
Example:
```
bpftrace -e 'config = { stack_mode = raw } kprobe:vfs_read { @ = kstack; exit() }'
bpftrace -e 'config = { stack_mode = raw } kprobe:vfs_read { @[kstack] = 0; exit() }'
bpftrace -e 'config = { stack_mode = raw } kprobe:vfs_read { $s = kstack; print($s); exit() }'
```
All of these would have the default 'bpftrace'
stack mode instead of 'raw'.
jordalgo
force-pushed
the
stack_mode_map_printing
branch
from
5780653 to
7947a9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stack mode for kstack and ustack builtin
variables (i.e. without ()) were not respecting
the stack mode value set by the config block.
Example:
All of these would have the default 'bpftrace'
stack mode instead of 'raw'.
Checklist
man/adoc/bpftrace.adocCHANGELOG.md