cmake: libbpf: Require at least v1.0 #3212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danobi
force-pushed
the
libbpf_requirement
branch
from
ff07bd7 to
0a87f1e
Compare
|
I'm not entirely sure what this means "Libbpf version too old to have libbpf_version.h" |
danobi
force-pushed
the
libbpf_requirement
branch
from
0a87f1e to
f141cdb
Compare
|
@jordalgo I added a source comment to clarify. Lemme know if you have wording suggestions. |
jordalgo
reviewed
Jun 2, 2024
bpftrace relies on libbpf 1.0 b/c the 1.0 release contained major API breaks. Going forward from 1.0, we can feature detect and expect backwards compat. This commit makes it so the error is more apparent on older systems. Otherwise you just get confusing build failures. Now you get: ``` 0.763 -- Found LibBpf: /usr/lib/x86_64-linux-gnu/libbpf.so 0.763 CMake Error at cmake/FindLibBpf.cmake:48 (message): 0.763 Libbpf version too old to have libbpf_version.h 0.763 Call Stack (most recent call first): 0.763 CMakeLists.txt:84 (find_package) 0.763 0.763 0.763 -- Performing Test HAVE_LIBBPF_UPROBE_MULTI 0.791 -- Performing Test HAVE_LIBBPF_UPROBE_MULTI - Failed 0.791 CMake Error at CMakeLists.txt:87 (message): 0.791 bpftrace requires libbpf 1.0 or greater ``` This closes bpftrace#3210.
danobi
force-pushed
the
libbpf_requirement
branch
from
f141cdb to
bec7d54
Compare
jordalgo
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpftrace relies on libbpf 1.0 b/c the 1.0 release contained major API breaks. Going forward from 1.0, we can feature detect and expect backwards compat.
This commit makes it so the error is more apparent on older systems. Otherwise you just get confusing build failures. Now you get:
This closes #3210.
Checklist
man/adoc/bpftrace.adocCHANGELOG.md