Move error printing from debug to verbose mode #3202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a class of recoverable errors which may occur for every execution of bpftrace in some conditions (e.g. errors depending on the availability of system features, like BTF). For such cases, we don't want to bother the user by printing the error every time, so we only print them when output verbosity is increased. The problem is that we sometimes show the errors in the verbose mode but sometimes in the debug mode. This change unifies the approach to show all the errors in the verbose mode (i.e. with -v). The errors moved to -v are: - BTF loading errors - Clang parser errors - error reading /sys/kernel/tracing/available_filter_functions
The input never changes, it always has the form:
#include </bpftrace/include/__btf_generated_header.h>
... definitions from the script ...
so it doesn't make much sense to print it.
viktormalik
force-pushed
the
cli-verbose-errs
branch
from
c483e01 to
d9e3268
Compare
jordalgo
approved these changes
May 28, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a class of recoverable errors which may occur for every execution of bpftrace in some conditions (e.g. errors depending on the availability of system features, like BTF).
For such cases, we don't want to bother the user by printing the error every time, so we only print them when output verbosity is increased. The problem is that we sometimes show the errors in the verbose mode but sometimes in the debug mode.
This change unifies the approach to show all the errors in the verbose mode (i.e. with
-v). The reasoning is that the debug mode is intended for bpftrace developers while these errors may be useful to the user to hint him why the program is not working as expected.The errors moved to
-vare:Also, this drops printing
ClangParserinput in the debug mode as the input never changes during bpftrace execution so there's no point in printing it.Checklist
man/adoc/bpftrace.adocCHANGELOG.md