btf: Fix field resolution on structs with anon unions #2964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danobi
force-pushed
the
field_resolution
branch
from
bb2003c to
56fa8d7
Compare
viktormalik
reviewed
Jan 30, 2024
Before, we failed to correctly resolve fields in structs whose first field(s) were anonymous unions. This is b/c we incorrectly early terminated the loop through the struct's members during resolution. Fix by changing the incorrect return to a continue. Without the fix, the included test would fail trying to find `c`.
danobi
force-pushed
the
field_resolution
branch
from
56fa8d7 to
5008de2
Compare
viktormalik
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we failed to correctly resolve fields in structs whose first field(s) were anonymous unions. This is b/c we incorrectly early terminated the loop through the struct's members during resolution.
Fix by changing the incorrect return to a continue. Without the fix, the included test would fail trying to find
c.Checklist
man/adoc/bpftrace.adocand if needed indocs/reference_guide.mdCHANGELOG.md