Fix attachment/listing of wildcarded module kfuncs #2914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktormalik
force-pushed
the
kfunc-mod-fix
branch
from
5dd8ba1 to
ef7dece
Compare
3 tasks
jordalgo
reviewed
Jan 11, 2024
Attachment to e.g. all functions in a module is broken:
# bpftrace -e 'kfunc:nvme:*' { @[func] = count() }
No probes to attach
This fixes the bug causing the above problem:
# bpftrace -e 'kfunc:nvme:*' { @[func] = count() }
Attaching 65 probes...
[...]
Also adds a runtime tests to check for future regressions.
viktormalik
force-pushed
the
kfunc-mod-fix
branch
from
ef7dece to
9cee352
Compare
jordalgo
approved these changes
Jan 11, 2024
danobi
approved these changes
Jan 15, 2024
| @@ -45,6 +45,16 @@ REQUIRES lsmod | grep '^nf_tables' | |||
| REQUIRES /usr/sbin/nft --help | |||
| CLEANUP nft delete table bpftrace | |||
|
|
|||
| NAME kernel_module_attach_wildcard | |||
There was a problem hiding this comment.
Would be neat to have a NEW_NETNS runtime test directive to provide a little more isolation. But not needed for now
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attachment to e.g. all functions in a module is broken:
This fixes the bug causing the above problem:
Also adds a runtime tests to check for future regressions.
Checklist
man/adoc/bpftrace.adocand if needed indocs/reference_guide.mdCHANGELOG.md