Enable watchpoint support for PowerPC #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dubeyabhishek
requested review from
ajor,
viktormalik,
danobi and
fbs
as code owners
danobi
reviewed
Apr 24, 2023
dubeyabhishek
force-pushed
the
master
branch
2 times, most recently
from
386edea to
b5bee5d
Compare
|
Can you please rebase your commit instead of mergning the master? |
|
Done @viktormalik |
|
@danobi @viktormalik is anything pending from my side for this one? |
|
No, let's just wait for @danobi to approve (since he's the original author of the watchpoint support) and we can merge. |
danobi
approved these changes
Apr 27, 2023
|
Oh, mind updating the changelog? |
|
@danobi I have updated section from 9.4 to 10.4 |
Ah, no, he meant to add entry into the |
PowerPC supports data watchpoint through DAWR register. The invalid watchpoint modes referenced from PowerISA Book III v3.1B, Section 5.4.4 and 10.4 Signed-off-by: Abhishek Dubey <[email protected]>
|
Thanks @viktormalik |
viktormalik
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PowerPC supports data watchpoint through DAWR register. The invalid watchpoint modes referenced from
PowerISA Book III v3.1B, Section 5.4.4 and 10.4