Treat str() builtin's len parameter as int64 #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenhengqi
requested review from
ajor,
viktormalik,
danobi and
fbs
as code owners
viktormalik
approved these changes
Mar 30, 2023
The len parameter to str() should be treated as int64, so that the LHS and RHS to IRBuilder::CreateICmp() is of the same type. Otherwise, this would trigger an assertion failure in the ICmpInst constructor. Closes bpftrace#2544. Signed-off-by: Hengqi Chen <[email protected]>
danobi
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The len parameter to str() should be treated as int64,
so that the LHS and RHS to IRBuilder::CreateICmp() is of
the same type. Otherwise, this would trigger an assertion
failure in the ICmpInst constructor.
Closes #2544.
Checklist
man/adoc/bpftrace.adocand if needed indocs/reference_guide.mdCHANGELOG.md