Probe matcher: don't fail on missing files #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minipli-oss
requested review from
ajor,
viktormalik,
danobi,
fbs and
BurntBrunch
as code owners
viktormalik
reviewed
Nov 21, 2022
Even though we rely on ftrace's function tracing functionality to list available probe functions, bpftrace can work without these, e.g. when making use of tracepoints only. Right now `bpftrace -l` will die with a std::runtime_error exception if called on a kernel that lacks CONFIG_FUNCTION_TRACER. This isn't exactly user friendly. Instead of dying by throwing an exception, emit a warning and keep on going. This makes bpftrace usable on systems that lack CONFIG_FUNCTION_TRACER and/or CONFIG_EVENT_TRACING -- with limited functionality, of course! Signed-off-by: Mathias Krause <[email protected]>
minipli-oss
force-pushed
the
tracefs_non_fatal
branch
from
4263ca8 to
095ffbd
Compare
|
Thanks for the review! I added the changelog entry and updated the branch. |
viktormalik
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we rely on ftrace's function tracing functionality to list available probe functions, bpftrace can work without these, e.g. when making use of tracepoints only.
Right now
bpftrace -lwill die with astd::runtime_errorexception if called on a kernel that lacksCONFIG_FUNCTION_TRACER. This isn't exactly user friendly.Instead of dying by throwing an exception, emit a warning and keep on going.
This makes bpftrace usable on systems that lack
CONFIG_FUNCTION_TRACERand/orCONFIG_EVENT_TRACING-- with limited functionality, of course!Signed-off-by: Mathias Krause [email protected]
Checklist
man/adoc/bpftrace.adocand if needed indocs/reference_guide.mdCHANGELOG.md