Pipe helper errors into normal text and json output #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktormalik
reviewed
Aug 15, 2022
Helper errors (-k or -kk) are currently only visible on stderr. Change that behavior to emit them to text output (-o) and in JSON format. This allows tools that process the JSON output to account for the errors, similarly to lost perf events.
BurntBrunch
force-pushed
the
json-helper-errors
branch
from
4d7b59d to
9b659e0
Compare
|
Fixed clang format and added a changelog entry. |
danobi
approved these changes
Aug 16, 2022
viktormalik
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helper errors (-k or -kk) are currently only visible on stderr.
Change that behavior to emit them to text output (-o) and in JSON
format.
This allows tools that process the JSON output to account for the
errors, similarly to lost perf events.
Checklist
CHANGELOG.md