iter: Reuse BPFtrace::run() infrastructure #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbs
approved these changes
Jun 29, 2021
Instead of `iter` probes having its own runtime codepath, this commit integrations iter probes with other probe types. The only difference now is that instead of polling indefinitely for perf buffer events, we read the link FD until it's emptied and then proceed to exit. This is advantageous b/c now features like `-kk` will work (b/c the perf buffers are set up now). This also makes builtins like `elapsed` work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
iterprobes having its own runtime codepath, this commitintegrations iter probes with other probe types. The only difference now
is that instead of polling indefinitely for perf buffer events, we read
the link FD until it's emptied and then proceed to exit.
This is advantageous b/c now features like
-kkwill work (b/c the perfbuffers are set up now). This also makes builtins like
elapsedwork asexpected.
Checklist
docs/reference_guide.mdCHANGELOG.md