Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kheader: Do not unpack kheaders if system has BTF #1740

Merged
merged 3 commits into from
Mar 19, 2021

Conversation

danobi
Copy link
Member

@danobi danobi commented Mar 18, 2021

There's no need for kernel headers if the system has BTF. Unpacking
in-kernel headers is extra work for no gain.

Checklist
  • Language changes are updated in docs/reference_guide.md
  • User-visible and non-trivial changes updated in CHANGELOG.md
  • The new behaviour is covered by tests

danobi added 3 commits March 18, 2021 16:07
Reads a little better than comparing equality
There's no need for kernel headers if the system has BTF. Unpacking
in-kernel headers is extra work for no gain.
@danobi danobi requested a review from olsajiri March 19, 2021 16:16
Copy link
Contributor

@olsajiri olsajiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, tests are passing for me

@danobi danobi merged commit 13d3a85 into bpftrace:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants