Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mips64 reg #1599

Closed
wants to merge 1 commit into from
Closed

add mips64 reg #1599

wants to merge 1 commit into from

Conversation

George-Hu
Copy link

Checklist
  • Language changes are updated in docs/reference_guide.md
  • User-visible and non-trivial changes updated in CHANGELOG.md
  • The new behaviour is covered by tests

add mips64 reg
@mmisono
Copy link
Collaborator

mmisono commented Nov 14, 2020

Could you update the CHANGELOG.md?

@mmisono
Copy link
Collaborator

mmisono commented Nov 14, 2020

Also, bpftrace has architecture-specific tests for register access: https://github.com/iovisor/bpftrace/blob/master/tests/runtime/intptrcast . It would be great to add MIPS tests as well.

@danobi
Copy link
Member

danobi commented Nov 19, 2020

Yeah, some basic tests would be nice

@fbs
Copy link
Member

fbs commented Nov 26, 2020

@George-Hu can you add in a changelog entry?

Tests would be nice too

@fbs fbs mentioned this pull request Feb 23, 2021
@fbs
Copy link
Member

fbs commented Feb 23, 2021

#1708 for the changelog

@fbs fbs closed this Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants