Fix LNOT #1570
Merged
Fix LNOT #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbs
reviewed
Oct 26, 2020
| } | ||
| else | ||
| { | ||
| unop.type = CreateUInt(8 * type.size); |
There was a problem hiding this comment.
shouldn't we just return a fixed size int here? Logical not should give a boolean so u64 might be better?
But not sure hwo much that will break.
There was a problem hiding this comment.
I'm not sure but with #1532, there is a chance that bytecode size becomes smaller?
There was a problem hiding this comment.
Not sure. I Wouldn't mind keeping this PR as is an investigate it further in #1532 & friends
CreateUint() expects bit size, not byte size. This fixes the following
error.
```
% sudo ./src/bpftrace -e 'BEGIN { !(int32)0 }'
bpftrace: /home/ubuntu/work/bpftrace/src/types.cpp:251: bpftrace::SizedType bpftrace::CreateInteger(size_t, bool): Assertion `bits == 0 || bits == 8 || bits == 16 || bits == 32 || bits == 64' failed.
zsh: abort sudo ./src/bpftrace -e 'BEGIN { !(int32)0 }'
```
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateUint() expects bit size, not byte size. This fixes the following
error.
Checklist
docs/reference_guide.mdCHANGELOG.md