Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config, enable method and more tests #90

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Conversation

schinery
Copy link
Contributor

Changes include:

  • Added ability to turn logging on and off (like Papertrail)
  • Added config
  • Removed hardcoded EXCLUDE_* as they are now set via the new config
  • Added tests
  • Updated README (could still do with some more work)

@schinery schinery force-pushed the enable-flag-and-config branch from 1bb1d30 to 52b6ef3 Compare August 22, 2022 07:48
@schinery schinery marked this pull request as ready for review August 22, 2022 07:51
Copy link
Contributor

@MattHall MattHall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the changes to the EXCLUDED_KEYS, will there we a corresponding PR in the including apps to set these to include these in the configuration?

@schinery
Copy link
Contributor Author

With the changes to the EXCLUDED_KEYS, will there we a corresponding PR in the including apps to set these to include these in the configuration?

@MattHall yeah was thinking I'll bump this a major version and create a PR to bump and add the config.

@schinery schinery merged commit cf78758 into main Aug 22, 2022
@schinery schinery deleted the enable-flag-and-config branch August 22, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants