[N/A] Convert gem to be a rubocop extension #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jivdhaliwal
force-pushed
the
convert-gem-to-rubocop-extension
branch
from
489636c to
00dbb8e
Compare
schinery
approved these changes
Oct 2, 2023
Revert back to the original implementation for removing new lines and avoid any issues if there are extra characters on the new line.
jivdhaliwal
commented
Oct 2, 2023
|
|
||
| module RuboCop | ||
| module Boxt | ||
| VERSION = File.read(File.join(File.dirname(__FILE__), "../../../VERSION")).split("\n").first |
There was a problem hiding this comment.
It was struggling to find the VERSION file when running rubocop in our danger workflow directory so I updated it to use a relative path @schinery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the gem to follow the conventions in https://github.com/rubocop/rubocop-extension-generator which is used to generate all of the rubocop gems we use (
rubocop-rspec,rubocop-rails,rubocop-performance, etc).Converting the gem to a rubocop extension allows us to use the
boxt_rubocoprubocop config by simply requiring it as we do other rubocop gems:It also has the added benefit of having proper support for custom cops. This means that we can now create custom cops without having to worry about manually disabling them in every project we don't want to use them in.
I have left the
rails.ymlandrspec.ymlconfigs as separate files that can be imported individually usinginherit_gem:If we decide that any of these configs should be enabled by default we can simply move them in to
config/default.yml.