Feature : Add Slots to Component Reference #642
Conversation
Slots will now appear on references.
|
One small problem, BTable and its detail-row functionality does not work as intended. Seems that the row object does not have the reactive property established and therefore does not update on click but on page reload. Thought I could add something to fix it but I am sure there is a better way to establish the reactivity and I could not think of a way. |
|
Not exactly sure what's going on with your changelog Could the reactivity issue have to do with https://github.com/cdmoro/bootstrap-vue-3/blob/b71df9dbe9b835b16b4163746158f9b7bc895640/packages/bootstrap-vue-3/src/components/BTable/BTable.vue#L99 Being wrapped in a function? It may be odd, but I think the slot may be losing reactivity because of this. The |
|
There's a copy of mine. I deleted the one on this PR because I thought it would fix it showing that it was changed... It doesn't technically matter, if it manages to get deleted during a merge of this PR, I will add it back in manually. Tbh I'm surprised I'm allowed to delete items from a PR that exist from a fork 🤔 |
Thanks, I saw that too and was wondering what was going on. I am going to just keep looking real quick to see what's going on with the row detail |
I mentioned to the active contributor that has been working on the table component, but he never messaged back. He has an active pr on the table, if you want, I'm sure he will eventually come to a solution, or you can message him yourself and you can both work to find a solution, or find it yourself. |
Could you please post an example code to replicate the issue? I need to understand where is the issue exactly |
|
If detail-row has an issue, lets move it to an issue. Rather than multiple PRs |
|
@aceofwings i just need the code you are using to see what i can do about it. |
4 participants
Describe the PR
Add Slots to Component Reference
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)feat(...)fix(...)docs(...)The PR fulfills these requirements:
CHANGELOGis generated from these messages, and determines the next version typeBEGIN_COMMIT_OVERRIDE
docs: add slots to component reference
END_COMMIT_OVERRIDE