This repository has been archived by the owner on Mar 9, 2019. It is now read-only.
no need to call Truncate and Sync if size is not changed #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -45,10 +45,10 @@ func funlock(f *os.File) error { | |||
| } | |||
|
|
|||
| // mmap memory maps a DB's data file. | |||
| func mmap(db *DB, sz int) error { | |||
| func mmap(db *DB, sz int, changesize bool) error { | |||
There was a problem hiding this comment.
Can you change the variable name to syncRequired? I think it makes more sense within the context of the function.
There was a problem hiding this comment.
Oh, I just found that I forgot about bolt_windows.go where is no call to Sync.
Sync looks to be helper method, and call to Truncate is the main.
So, I think changeSize is semantically better name.
More: calling to Truncate looks to also take non-zero time.
There was a problem hiding this comment.
well, I remade it completely: move decision logic to db.mmap
it is an issue for opening file: size is really the same. and Truncate+Sync slows Open very much: from 20000open/sec to 50open/sec
funny-falcon
force-pushed
the
do_not_sync_on_open
branch
from
11c882b
to
f97bb12
Compare
|
looks like it was fixed by e67705ed6348675b7b |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#284 mentions that Sync should be called on size change.
But if size is not changed, why Sync is called?
It is an issue for opening file: size is really the same.
Truncate+Sync slows Open very much: if 10 concurrent small files are opening, then speed drops from 20000open/sec to 50open/sec