-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ValueError in get_graph_kwargs #14022
Fix ValueError in get_graph_kwargs #14022
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.6 #14022 +/- ##
=============================================
Coverage ? 93.16%
=============================================
Files ? 282
Lines ? 19850
Branches ? 0
=============================================
Hits ? 18494
Misses ? 1356
Partials ? 0 |
The value is in providing a more tailored exception message with more information for the user. Similar to the other PR it would be good to add some tests for these codepaths since evidently they were missing. |
Added a test: 079b336 |
Thanks @cdeil ! |
* Fix ValueError in get_graph_kwargs * Add Test_get_graph_kwargs::test_bad_input
* Fix ValueError in get_graph_kwargs * Add Test_get_graph_kwargs::test_bad_input
This PR fixes the warning I see in PyCharm static code analysis:
This seems to work:
Is it really useful to catch a ValueError and raise another?
Apply this fix here or instead remove the whole try/except?