Fix HTML/CSS warning for palette group detail #14021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.6 #14021 +/- ##
=============================================
Coverage ? 93.10%
=============================================
Files ? 282
Lines ? 19850
Branches ? 0
=============================================
Hits ? 18481
Misses ? 1369
Partials ? 0 |
|
@cdeil for completeness can you post a screenshot of a local docs render to document that things render as expected? |
|
LGTM on local docs build (with Chrome on MacOS): 
|
bryevdv
approved these changes
Aug 12, 2024
|
Thanks @cdeil |
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warning that HTML width attribute on table td is obsolete and follow recommendation to use CSS instead:
See https://www.w3.org/TR/2010/WD-html-markup-20100624/td.html
One thing I noticed at https://docs.bokeh.org/en/latest/docs/reference/palettes.html is that (with Chrome, Safari, Firefox all the same) I see for large palettes like
Category20corIridescentthat the widths are not equal when displayed. That's before this PR, i.e. unrelated.