Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (branch-3.6@5aecc61). Learn more about missing BASE report.

@@              Coverage Diff              @@
##             branch-3.6   #14020   +/-   ##
=============================================
  Coverage              ?   93.20%           
=============================================
  Files                 ?      282           
  Lines                 ?    19850           
  Branches              ?        0           
=============================================
  Hits                  ?    18501           
  Misses                ?     1349           
  Partials              ?        0           

While you are at it, I would suggest adding some simple with pytest.raises(...) style of tests to cover those cases.

I have not managed to get a proper dev setup working yet on MacOS, still struggling with various issues. So would appreciate if you could add more tests if needed for now.

There's no pressing hurry, it seems like this would be a good context to get tests up and running locally.

This now works for me:

pytest --cov=bokeh --cov-report=html -m "not selenium" tests/unit

Is it the proper way or are there other relevant tests?

It looks like there's missing unit test coverage here for some types of patches and not just the exception handler lines I fixed:

I'm really not familiar with this code at all and don't know what "correct" would look like here, what inputs exactly should or shouldn't work. Would be great if someone familiar with the code can add the missing test(s) and finish this up!

@cdeil I would expect the tests for error conditions would all look very similar to this (untested):

def test_bad_negative_index() -> None:
    source = ColumnDataSource(data=dict(foo=[1]))
    bad_patch = dict(foo=(-1, 10))

    msg = "Out-of bounds index (-1) in patch for column: foo"
    with pytest.raises(ValueError, match=msg):
        source.patch(bad_patch)

The hierarchy for test files under tests/unit exactly matches the library file hierarchy with test_ prefixed, so this would go in the corresponding test_sources.py module.

I'm not sure when I would be able to add tests so we can just leave this open for the time being.

Added some tests: b7cdbe0

Thanks @cdeil !

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.