Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip empty sequences when streaming with ndarrays #14007

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Aug 1, 2024

fixes #14004

@mattpap mattpap added this to the 3.6 milestone Aug 1, 2024
@mattpap mattpap force-pushed the mattpap/14004_stream_concat branch from 8f0c1c8 to 92b48c4 Compare August 2, 2024 18:03
@mattpap mattpap force-pushed the mattpap/14004_stream_concat branch from 92b48c4 to 2cfe0fb Compare August 2, 2024 18:42
@mattpap mattpap requested a review from bryevdv August 2, 2024 18:42
@mattpap
Copy link
Contributor Author

mattpap commented Aug 2, 2024

I improved the typing situation and added numpy to bokeh info to make sure what version we are working with.

@mattpap
Copy link
Contributor Author

mattpap commented Aug 2, 2024

Finally I added print_info() function equivalent to bokeh info, used like this:

$ git diff
diff --git a/examples/basic/scatters/color_scatter.py b/examples/basic/scatters/color_scatter.py
index 1f3770efa7..a7d62cbef9 100644
--- a/examples/basic/scatters/color_scatter.py
+++ b/examples/basic/scatters/color_scatter.py
@@ -10,6 +10,9 @@ many different plot tools.
 import numpy as np
 
 from bokeh.plotting import figure, show
+from bokeh.util.info import print_info
+
+print_info()
 
 N = 4000
 x = np.random.random(size=N) * 100
$ BOKEH_DEV=true python examples/basic/scatters/color_scatter.py 
Python version        :  3.12.3 | packaged by conda-forge | (main, Apr 15 2024, 18:38:13) [GCC 12.3.0]
IPython version       :  8.19.0
Tornado version       :  6.3.3
NumPy version         :  2.0.1
Bokeh version         :  3.6.0.dev1+20.gb902fb51
BokehJS static path   :  /home/anaconda/repo/bokeh/bokehjs/build
node.js version       :  v20.12.2
npm version           :  10.8.2
jupyter_bokeh version :  4.0.5
Operating system      :  Linux-5.15.0-113-generic-x86_64-with-glibc2.35

@mattpap mattpap force-pushed the mattpap/14004_stream_concat branch from d89e68f to 135f58f Compare August 3, 2024 09:05
@mattpap mattpap force-pushed the mattpap/14004_stream_concat branch from 135f58f to 92bba7f Compare August 3, 2024 09:28
@mattpap mattpap merged commit 61b87ac into branch-3.6 Aug 6, 2024
22 checks passed
@mattpap mattpap deleted the mattpap/14004_stream_concat branch August 6, 2024 07:22
@mattpap mattpap mentioned this pull request Aug 22, 2024
12 tasks
mattpap added a commit that referenced this pull request Aug 22, 2024
* Skip empty sequences when streaming with ndarrays

* Add NumPy version to bokeh info

* Add release notes

* Add print_info() utility function equivalent of `bokeh info`
@mattpap mattpap modified the milestones: 3.6, 3.5.2 Aug 22, 2024
Chiemezuo pushed a commit to Chiemezuo/bokeh that referenced this pull request Aug 27, 2024
* Skip empty sequences when streaming with ndarrays

* Add NumPy version to bokeh info

* Add release notes

* Add print_info() utility function equivalent of `bokeh info`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Numpy.datetime64 does not work when streaming
2 participants