Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSE-4343: Fix sccache in pip build #25

Merged
merged 12 commits into from
Dec 6, 2024
Merged

Conversation

IsaacWarren
Copy link
Contributor

@IsaacWarren IsaacWarren commented Dec 6, 2024

Changes included in this PR

Switches variable used to enable sccache/ccache to the one recommended by cmake

Testing strategy

https://github.com/bodo-ai/Bodo/actions/runs/12206645597
Confirmed locally ccache was used

User facing changes

NA

Checklist

  • Pipelines passed before requesting review. To run CI you must include [run CI] in your commit message.
  • I am familiar with the Contributing Guide
  • I have installed + ran pre-commit hooks.

Copy link
Contributor

@hadia206 hadia206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Isaac

@IsaacWarren IsaacWarren merged commit 8185701 into main Dec 6, 2024
31 of 32 checks passed
@IsaacWarren IsaacWarren deleted the isaac/update-conda-lock branch December 6, 2024 23:46
hadia206 pushed a commit that referenced this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants