Rewrote the test using fake controllers.yaml. Moved test to cli suite.

bnhassin · Sep 19, 2022 · a12b468 · a12b468
1 parent 713bdfd
commit a12b468
Show file tree

Hide file tree

Showing 4 changed files with 58 additions and 50 deletions.
diff --git a/tests/suites/cli/task.sh b/tests/suites/cli/task.sh
@@ -17,6 +17,7 @@ test_cli() {
 	test_local_charms
 	test_model_config
 	test_model_defaults
+	test_unregister
 
 	destroy_controller "test-cli"
 }
diff --git a/tests/suites/cli/unregister.sh b/tests/suites/cli/unregister.sh
@@ -0,0 +1,57 @@
+run_unregister() {
+	echo
+
+	echo "Create temporary controllers.yaml file"
+	mkdir -p "${TEST_DIR}/juju"
+	echo "" >>"${TEST_DIR}/juju/controllers.yaml"
+
+	CONTROLLERS=$(
+		cat <<'EOF'
+controllers:
+    unregister-test:
+        uuid: c2a22492-e551-4856-850c-f3df36e9a828
+        api-endpoints: ['10.209.4.183:17070']
+        ca-cert: |
+            -----BEGIN CERTIFICATE-----
+            XXX==
+            -----END CERTIFICATE-----
+        cloud: lxd
+        region: default
+        type: lxd
+        agent-version: 2.9.35.1
+        controller-machine-count: 1
+        active-controller-machine-count: 0
+        machine-count: 1
+EOF
+	)
+
+	echo "Set fake data about unregister-test controller in controllers.yaml"
+	echo "${CONTROLLERS}" >>"${TEST_DIR}/juju/controllers.yaml"
+
+	echo "Unregister the unregister-test controller"
+	JUJU_DATA="${TEST_DIR}/juju" juju unregister --yes "unregister-test"
+
+	echo "Check that temporary controllers.yaml has no controllers' data"
+	EXPECTED="controllers: {}"
+	OUT=$(cat "${TEST_DIR}/juju/controllers.yaml" )
+	if [ "${OUT}" != "${EXPECTED}" ]; then
+		echo "expected ${EXPECTED}, got ${OUT}"
+		exit 1
+	fi
+
+}
+
+test_unregister() {
+	if [ -n "$(skip 'test_unregister')" ]; then
+		echo "==> SKIP: Asked to skip controller unregister tests"
+		return
+	fi
+
+	(
+		set_verbosity
+
+		cd .. || exit
+
+		run "run_unregister"
+	)
+}
diff --git a/tests/suites/controller/task.sh b/tests/suites/controller/task.sh
@@ -16,7 +16,6 @@ test_controller() {
 	test_enable_ha
 	# Leave this one last, as it can cause mongo to slowdown to a snails pace.
 	test_mongo_memory_profile
-	test_unregister
 
 	destroy_controller "test-controller"
 }
diff --git a/tests/suites/controller/unregister.sh b/tests/suites/controller/unregister.sh