Transaction: add back 2 deprecated constructors #3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move most of `Transaction.read` into a private constructor. Use this constructor to add back 2 removed constructors as deprecated constructors.
msgilligan
force-pushed
the
msgilligan/rel-0.17-Transaction-add-back-2-dep-methods
branch
from
a89b6de
to
d64d663
Compare
schildbach
reviewed
Sep 11, 2024
| /** @deprecated use {@link Transaction#readOutputs(ByteBuffer)} */ | ||
| @Deprecated | ||
| public Transaction(NetworkParameters parameters, byte[] payload) { | ||
| this(ByteBuffer.wrap(payload), ProtocolVersion.CURRENT.intValue()); |
There was a problem hiding this comment.
I wonder if ProtocolVersion.CURRENT.intValue() is always correct here. Did you look at how 0.16 deals with it? I just tried and sadly it's non-trivial.
There was a problem hiding this comment.
Maybe we should reduce the scope of this PR to just the refactoring that moves most of read() into a private constructor?
There was a problem hiding this comment.
Would this be enough to cover the need of LDK? Then sure, the less changes the better.
There was a problem hiding this comment.
Moving most of read() into a private constructor does not change the public API in any way, so it won't help LDK. It only makes any subsequent changes to constructors easier.
| /** @deprecated use {@link Transaction#readOutputs(ByteBuffer)} */ | ||
| @Deprecated | ||
| public Transaction(NetworkParameters parameters, byte[] payload, int offset) { | ||
| this(ByteBuffer.wrap(payload, offset, payload.length - offset), ProtocolVersion.CURRENT.intValue()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move most of
Transaction.readinto a private constructor. Use this constructor to add back 2 removed constructors as deprecated constructors.